Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing distribution validation for move_collection_version and copy_collection_version endpoints #1702

Open
jerabekjiri opened this issue Dec 11, 2023 · 0 comments

Comments

@jerabekjiri
Copy link
Contributor

AAH Issue: https://issues.redhat.com/browse/AAH-2852

Version

pulp-ansible         0.20.2
galaxy-ng            4.9.0

Describe the bug
move_collection_version and copy_collection_version endpoints are missing validation if destination repository has no distribution. Task is completed, but the user doesn't get notified about which repositories succeeded or failed.

To Reproduce

  1. Create a repository without distribution (foobar)
  2. /api/galaxy/pulp/api/v3/repositories/ansible/ansible/{pulp_id}/move_collection_version/
 {
  "destination_repositories": [
    "<foobar pulp_href>"
  ],
  "collection_versions": ...
  "signing_service": ...
}
  1. Task completed, but collection is not in the repository.

Expected behavior
Return an error message with missing distributions before dispatching the task
or alternatively, fail the task with an error about missing distributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant