Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

container repository output differs from container repository --help #1095

Open
simenon opened this issue Sep 25, 2024 · 2 comments
Open

container repository output differs from container repository --help #1095

simenon opened this issue Sep 25, 2024 · 2 comments
Labels
bug Something isn't working (template-set) Triage-Needed Needs to be reviewed at next pulp-cli mtg

Comments

@simenon
Copy link

simenon commented Sep 25, 2024

Version

"versions": [
    {
      "component": "core",
      "version": "3.61.0",
      "package": "pulpcore",
      "module": "pulpcore.app",
      "domain_compatible": true
    },
    {
      "component": "ansible",
      "version": "0.22.1",
      "package": "pulp-ansible",
      "module": "pulp_ansible.app",
      "domain_compatible": false
    },
    {
      "component": "container",
      "version": "2.21.0",
      "package": "pulp-container",
      "module": "pulp_container.app",
      "domain_compatible": false
    },
    {
      "component": "deb",
      "version": "3.3.1",
      "package": "pulp_deb",
      "module": "pulp_deb.app",
      "domain_compatible": false
    },
    {
      "component": "gem",
      "version": "0.6.1",
      "package": "pulp-gem",
      "module": "pulp_gem.app",
      "domain_compatible": true
    },
    {
      "component": "maven",
      "version": "0.8.1",
      "package": "pulp-maven",
      "module": "pulp_maven.app",
      "domain_compatible": false
    },
    {
      "component": "ostree",
      "version": "2.4.3",
      "package": "pulp-ostree",
      "module": "pulp_ostree.app",
      "domain_compatible": true
    },
    {
      "component": "python",
      "version": "3.12.3",
      "package": "pulp-python",
      "module": "pulp_python.app",
      "domain_compatible": true
    },
    {
      "component": "rpm",
      "version": "3.27.1",
      "package": "pulp-rpm",
      "module": "pulp_rpm.app",
      "domain_compatible": true
    },
    {
      "component": "certguard",
      "version": "3.61.0",
      "package": "pulpcore",
      "module": "pulp_certguard.app",
      "domain_compatible": true
    },
    {
      "component": "file",
      "version": "3.61.0",
      "package": "pulpcore",
      "module": "pulp_file.app",
      "domain_compatible": true
    }
  ],

Describe the bug
Just noticed that when you use the command pulp container repository you don't get the same output compared to if you pass the --help option,

See below examples

pulp container repository
Usage: pulp container repository [OPTIONS] COMMAND [ARGS]...

Options:
  -t, --type [container|push]
  --help                       Show this message and exit.

Commands:
  label
  list
  role
  show
  tag
  task
  untag
  version

versus

pulp container repository --help
Usage: pulp container repository [OPTIONS] COMMAND [ARGS]...

Options:
  -t, --type [container|push]
  --help                       Show this message and exit.

Commands:
  content
  copy-manifest
  copy-tag
  create
  destroy
  label
  list
  role
  show
  sync
  tag
  task
  untag
  update
  version

this has also effect in the pulp shell showing not full command completion

pulp> container repository
label    list     role     show     tag      task     untag    version

To Reproduce
See above

Expected behavior
I would expect same output

Additional context
I was just thrown off by it when i was looking for the pulp container repository create help, which initially did not appear in the command list.

@simenon simenon added the Triage-Needed Needs to be reviewed at next pulp-cli mtg label Sep 25, 2024
@ipanova ipanova transferred this issue from pulp/pulp_container Oct 2, 2024
@mdellweg mdellweg added the bug Something isn't working (template-set) label Oct 2, 2024
@mdellweg
Copy link
Member

I think this has to do with the repository type.
When you call pulp container repository --type push, do you get different results?

I'm not quite sure this may be by design after all.

@simenon
Copy link
Author

simenon commented Oct 22, 2024

Below all variants. So yeah, it is somehow related to the type option. But that does not explain why pulp container repository and pulp container repository --help differ in output, and it has some effects in pulp-cli with command completion.

pulp container repository
Usage: pulp container repository [OPTIONS] COMMAND [ARGS]...

Options:
  -t, --type [container|push]
  --help                       Show this message and exit.

Commands:
  label
  list
  role
  show
  tag
  task
  untag
  version
pulp container repository --help
Usage: pulp container repository [OPTIONS] COMMAND [ARGS]...

Options:
 -t, --type [container|push]
 --help                       Show this message and exit.

Commands:
 content
 copy-manifest
 copy-tag
 create
 destroy
 label
 list
 role
 show
 sync
 tag
 task
 untag
 update
 version
pulp container repository --type push
Usage: pulp container repository [OPTIONS] COMMAND [ARGS]...
Try 'pulp container repository --help' for help.

Error: Missing command.
pulp container repository --type push --help
Usage: pulp container repository [OPTIONS] COMMAND [ARGS]...

Options:
  -t, --type [container|push]
  --help                       Show this message and exit.

Commands:
  label
  list
  remove-image
  role
  show
  tag
  task
  untag
  version
pulp container repository --type container
Usage: pulp container repository [OPTIONS] COMMAND [ARGS]...
Try 'pulp container repository --help' for help.

Error: Missing command.
pulp container repository --type container --help
Usage: pulp container repository [OPTIONS] COMMAND [ARGS]...

Options:
  -t, --type [container|push]
  --help                       Show this message and exit.

Commands:
  content
  copy-manifest
  copy-tag
  create
  destroy
  label
  list
  role
  show
  sync
  tag
  task
  untag
  update
  version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working (template-set) Triage-Needed Needs to be reviewed at next pulp-cli mtg
Projects
Status: Not Started
Development

No branches or pull requests

2 participants