Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Pages for Large Approvals #1977

Open
3 tasks
sec122 opened this issue Oct 23, 2024 · 0 comments
Open
3 tasks

Error Pages for Large Approvals #1977

sec122 opened this issue Oct 23, 2024 · 0 comments
Labels

Comments

@sec122
Copy link

sec122 commented Oct 23, 2024

Expected behavior

When approving an item in PDC, we expect the page to load with the banner about how the files are moving now.

Actual behavior

When approving items containing more than 20k files and directories, it produces an error page saying "Looks like something went wrong"
image

If you try to reload the describe page at this stage, it will either:
a) not reload (timing out to a "looks like something went wrong page) or
b) it'll reload and it may or may not look like the approval was successful.
However, (in cases where it looks like the approval did not work) if you wait 5-10 minutes and are able to reload the describe page again, it may change to "approved" even though no further action was taken (besides refreshing the page).

Steps to replicate

Approve a dataset with 20k or more files and directories.

Impact of this bug

We have to cross our fingers that everything is actually working ok even though we see a "something went wrong" message.
There is no way to know if the files are continuing to transfer over, so we just have to check back by reloading the describe page and see if the counts are going up (though in one case the describe page would always time out, so we had to ask RDSS. File transfers of this size are currently taking more than a single business day to complete (when items contain more than 20k files and directories).

Acceptance criteria

  • If this change touches any of the files referenced in .rubocop_todo.yml create a new ticket to address the rubocop todo.
  • The page will stop going to "looks like something went wrong"
  • The page in describe will show the normal banner for approvals

NOTE: this may be an area that becomes a feature request to show something like a progress tracker of how long remains before a dataset is approved and the publication is fully accessible.

Honeybadger link and code snippet, if applicable

Implementation notes, if any

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant