Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Record Page] Update position and display of button 'Where to find it' #4453

Open
1 of 6 tasks
christinach opened this issue Oct 18, 2024 · 1 comment
Open
1 of 6 tasks
Labels
PO (high value) PO reviewed and high value user experience Tickets related to user experience

Comments

@christinach
Copy link
Member

christinach commented Oct 18, 2024

Current display

Where to find it has white background color and is positioned below the Library location

Desired display

Where to find follows the same color scheme as the Request button (background-color: #3072AB; border-color: #3072AB; color: #ffffff;).
Where to find it is positioned in the same line and on the right side of the request button.

Acceptance criteria

  • Rename the button caption 'Where to find it' to 'Find on shelf'.
  • 'Find on shelf' follows the same color scheme as the 'Request' button (background-color: #3072AB; border-color: #3072AB; color: #ffffff;).
  • 'Find on shelf' is positioned in the same line and on the right side of the 'Request' button.
  • I can successfully use this feature with Voice Over in Safari.
  • I have checked this feature using one of the following browser extensions and confirmed that it does not add any level A or level AA issues:
    • axe dev tools
    • Lighthouse
    • Wave
  • ...

Notes

The figma diagrams were collectively reviewed during the Orangelight meeting 10/17/2024.

@christinach christinach added the user experience Tickets related to user experience label Oct 18, 2024
@christinach christinach added the PO (high value) PO reviewed and high value label Oct 18, 2024
@kevinreiss
Copy link
Member

The stackmap integration looks for html like this to decide where to inject the "Where to find it" button

<span data-map-location="firestone$stacks" data-location-library="Firestone Library" data-location-name="Stacks"></span>```

I believe it also scrapes the call number value looking for this selector class "holding-call-number" on the record page and "call-number" on the search results page. 

@christinach christinach self-assigned this Oct 21, 2024
christinach added a commit that referenced this issue Oct 21, 2024
christinach added a commit that referenced this issue Oct 22, 2024
christinach added a commit that referenced this issue Oct 22, 2024
Remove fron weight and padding from find on shelf button
sandbergja added a commit that referenced this issue Oct 22, 2024
@christinach christinach removed their assignment Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PO (high value) PO reviewed and high value user experience Tickets related to user experience
Projects
None yet
Development

No branches or pull requests

2 participants