Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the type field in PubNubMembershipMetadata #194

Merged
merged 17 commits into from
Dec 4, 2024

Conversation

jguz-pubnub
Copy link
Contributor

@jguz-pubnub jguz-pubnub commented Nov 22, 2024

feat(membership): add support for the type field in PubNubMembershipMetadata

feat(app-context): deprecate methods containing uuid parameter, introduce new versions

feat(app-context): deprecate methods containing include parameter of Bool type, introduce new versions

feat(app-context): deprecate remove(channel:custom:completion:), introduce new version

feat(app-context): replace PubNubUUIDMetadata with PubNubUserMetadata

feat(app-context): replace PubNubUUIDMetadataBase with PubNubUserMetadataBase

feat(app-context): add an alias for backward compatibility with the customer code using PubNubUUIDMetadata

feat(app-context): add an alias for backward compatibility with the customer code using PubNubUUIDMetadataBase

feat(listeners): replace PubNubUUIDMetadataChangeset with PubNubUserMetadataChangeset

feat(listeners): add an alias for backward compatibility with the customer code using PubNubUUIDMetadataChangeset

Copy link
Contributor

@parfeon parfeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good! :)
Just a few questions.

PubNubUser/Sources/PubNubUser.swift Show resolved Hide resolved
PubNubUser/Sources/User+PubNub.swift Outdated Show resolved Hide resolved
Sources/PubNub/APIs/Objects+PubNub.swift Show resolved Hide resolved
Sources/PubNub/APIs/Objects+PubNub.swift Outdated Show resolved Hide resolved
Sources/PubNub/APIs/Objects+PubNub.swift Show resolved Hide resolved
Sources/PubNub/Models/PubNubMembershipMetadata.swift Outdated Show resolved Hide resolved
@parfeon parfeon self-requested a review November 27, 2024 15:26
* Deprecate PubNub.IncludeFields and introduce PubNub.UserIncludeFields and PubNub.ChannelIncludeFields
* Replace ObjectsUUIDRouter with ObjectsUserRouter
* Replace other occurences of UUID with User in AppContext related code
* Other minor fixes
* Introduce new method for removing Channel metadata
* Fixes for acceptance tests
Copy link
Contributor

@parfeon parfeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jguz-pubnub
Copy link
Contributor Author

@pubnub-release-bot release

@jguz-pubnub jguz-pubnub changed the title Add membership type support Add the type field in PubNubMembershipMetadata Dec 4, 2024
@jguz-pubnub jguz-pubnub changed the title Add the type field in PubNubMembershipMetadata Add support for the type field in PubNubMembershipMetadata Dec 4, 2024
@jguz-pubnub jguz-pubnub changed the title Add support for the type field in PubNubMembershipMetadata Add support for the type field in PubNubMembershipMetadata Dec 4, 2024
@jguz-pubnub jguz-pubnub merged commit 7b131fb into master Dec 4, 2024
10 checks passed
@jguz-pubnub jguz-pubnub deleted the feat/membership-type branch December 4, 2024 11:05
@pubnub-release-bot
Copy link

🚀 Release successfully completed 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants