-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the type
field in PubNubMembershipMetadata
#194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jguz-pubnub
requested review from
parfeon,
wkal-pubnub and
marcin-cebo
as code owners
November 22, 2024 08:52
parfeon
reviewed
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good! :)
Just a few questions.
* Deprecate PubNub.IncludeFields and introduce PubNub.UserIncludeFields and PubNub.ChannelIncludeFields * Replace ObjectsUUIDRouter with ObjectsUserRouter * Replace other occurences of UUID with User in AppContext related code * Other minor fixes * Introduce new method for removing Channel metadata * Fixes for acceptance tests
jguz-pubnub
force-pushed
the
feat/membership-type
branch
from
November 27, 2024 17:12
ca74368
to
3e292cf
Compare
parfeon
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@pubnub-release-bot release |
jguz-pubnub
changed the title
Add membership type support
Add the type field in PubNubMembershipMetadata
Dec 4, 2024
jguz-pubnub
changed the title
Add the type field in PubNubMembershipMetadata
Add support for the type field in PubNubMembershipMetadata
Dec 4, 2024
jguz-pubnub
changed the title
Add support for the type field in PubNubMembershipMetadata
Add support for the Dec 4, 2024
type
field in PubNubMembershipMetadata
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(membership): add support for the
type
field inPubNubMembershipMetadata
feat(app-context): deprecate methods containing
uuid
parameter, introduce new versionsfeat(app-context): deprecate methods containing
include
parameter ofBool
type, introduce new versionsfeat(app-context): deprecate
remove(channel:custom:completion:)
, introduce new versionfeat(app-context): replace
PubNubUUIDMetadata
withPubNubUserMetadata
feat(app-context): replace
PubNubUUIDMetadataBase
withPubNubUserMetadataBase
feat(app-context): add an alias for backward compatibility with the customer code using
PubNubUUIDMetadata
feat(app-context): add an alias for backward compatibility with the customer code using
PubNubUUIDMetadataBase
feat(listeners): replace
PubNubUUIDMetadataChangeset
withPubNubUserMetadataChangeset
feat(listeners): add an alias for backward compatibility with the customer code using
PubNubUUIDMetadataChangeset