Subscribe & Presence Event Engine #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jguz-pubnub
requested review from
parfeon,
wkal-pubnub and
marcin-cebo
as code owners
* Adding `.connnectionError` and removing `.connecting` and `.reconnecting` from `ConnectionStatus` * Deprecating `SubscriptionSession` and `SubscribeSessionFactory` * Limiting the scope of public structs/classes associated with the Subscribe loop that aren't part of any exposed public method/variable * Introducing Strategy pattern to handle both old & new Subscribe loop implementation * Removing local events emitted from Subscribe loop * Maintaining `state` parameter for /v2/subscribe and /v2/presence/heartbeat * Adding `enableEventEngine` and `maintainPresenceState` flags in `PubNubConfiguration` * Improved AutomaticRetry and making possible to retry other requests * Fixing unit & contract tests according to changes above
* Handling filterExpression * Providing backward compatibility for SubscribeSessionFactory
* Providing full backward compatibility with old subscription loop * Always using PubNubError for any kind of errors
parfeon
requested changes
Jan 18, 2024
Sources/PubNub/EventEngine/Presence/Helpers/PresenceHeartbeatRequest.swift
Outdated
Show resolved
Hide resolved
Sources/PubNub/EventEngine/Presence/Helpers/PresenceHeartbeatRequest.swift
Outdated
Show resolved
Hide resolved
Sources/PubNub/EventEngine/Subscribe/Effects/SubscribeEffectFactory.swift
Show resolved
Hide resolved
parfeon
reviewed
Jan 19, 2024
Sources/PubNub/EventEngine/Subscribe/Effects/SubscribeEffectFactory.swift
Show resolved
Hide resolved
|
@pubnub-release-bot release as 6.3.0 |
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(subscribe & presence): introducing Subscribe & Presence EventEngine