Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced HeartbeatWaiting with HeartbeatCooldown. #136

Merged

Conversation

marcin-cebo
Copy link
Contributor

Replaced NEXT_HEARTBEAT with TIMES_UP

Replaced NEXT_HEARTBEAT with TIMES_UP
@kleewho
Copy link
Contributor

kleewho commented Jul 26, 2023

What about Wait effect?

Copy link
Contributor

@kleewho kleewho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you missed WAIT and CANCEL_WAIT effects

@marcin-cebo marcin-cebo merged commit 689185e into master Jul 26, 2023
6 checks passed
@marcin-cebo marcin-cebo deleted the mc_EE_Presence_HeartbeatCooldown_insteadOf_waiting branch July 26, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants