Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scholarsphere endpoint and client key as arguments #50

Open
ajkiessl opened this issue Feb 15, 2023 · 0 comments
Open

Scholarsphere endpoint and client key as arguments #50

ajkiessl opened this issue Feb 15, 2023 · 0 comments

Comments

@ajkiessl
Copy link

Right now we are using 'SS4_ENDPOINT' and 'SS_CLIENT_KEY' to set the API endpoint url and key. This requires any system using this gem to know to set those environment variables. This is not ideal.

It would be better to inject these dependencies as arguments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ajkiessl