Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Management #878

Open
awead opened this issue Sep 10, 2021 · 5 comments
Open

User Management #878

awead opened this issue Sep 10, 2021 · 5 comments
Labels
question Further information is requested

Comments

@awead
Copy link
Contributor

awead commented Sep 10, 2021

Currently there are over 247 million user records in the database, all of them "guest user" accounts created by the devise-guests gem. This is because user records are created for every new session. We need to curtail these.

Proposal

  1. Create a single "public user" record that serves as the current_user for everybody (this is what we do in Scholarsphere)
  2. Create a second "admin user" record that serves as the current_user for admin users or other users with elevated privileges
  3. Drop database Bookmarks in the catalg
  4. Remove the devise-guests gem

Related Issues

#836
#331

@awead
Copy link
Contributor Author

awead commented Sep 10, 2021

TL;DR we still have a users table, but there's only 2 rows in it: 1 for the public user, the other for admin user.

@banukutlu
Copy link
Contributor

thanks for adding this issue @awead, I like the public and admin user idea!

@whereismyjetpack
Copy link
Contributor

now that bookmarks are factored out, i don't see a problem with the proposal. Is the reason we need a user in the first place a blacklight-ism?

@awead
Copy link
Contributor Author

awead commented Sep 10, 2021

@whereismyjetpack I was just thinking that as well. Do we even need the concept of a database-backed user object? If the answer is no, then we probably don't even need Devise either.

@whereismyjetpack
Copy link
Contributor

Interesting. If we could have anonymous sessions and rid devise, we could remove some deps and MySQL!

@ruthtillman ruthtillman added the question Further information is requested label May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants