Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Move away from hbmqtt #59

Closed
pschmitt opened this issue Mar 3, 2021 · 6 comments · Fixed by #65
Closed

Tests: Move away from hbmqtt #59

pschmitt opened this issue Mar 3, 2021 · 6 comments · Fixed by #65

Comments

@pschmitt
Copy link
Owner

pschmitt commented Mar 3, 2021

poetry is unable to install hbmqtt 0.9.6: python-poetry/poetry#3649

and it is incompatible with Python 3.9: njouanin/hbmqtt#223

Viable alternatives 🤷:

@pschmitt pschmitt changed the title Move away from hbmqtt Tests: Move away from hbmqtt Mar 3, 2021
@pschmitt
Copy link
Owner Author

pschmitt commented Mar 3, 2021

Can you take a look @freekode?

@freekode
Copy link
Collaborator

freekode commented Mar 3, 2021

Yep, will check it out.

@FlorianLudwig
Copy link

FlorianLudwig commented Mar 10, 2021

Hi,

reporter of the mentioned poetry bug report and maintainer of the mentioned hbmqtt fork here :)

Our plan is to make a release soonish and publish under a new package name on pypi.

The module name will stay the same for the first release and later change.

@pschmitt
Copy link
Owner Author

Nice, please let us know when it hits pypi!

@FlorianLudwig
Copy link

@pschmitt

an alpha release is out the door:

amqtt==0.10.0a1

please note that while the package name changed, the module name is still hbmqtt

We do intend to change it later on though. For now we want to keep it a drop-in replacement.

This might be a problem if there is a project that includes both, hbmqtt as well as amqtt. While in general I assume this won't happen in most projects for home-assistant that might be a problem

@pschmitt
Copy link
Owner Author

pschmitt commented Mar 13, 2021

Glad to see that things are moving forward on your end.

Our CI indicates that amqtt isn't quite 100% compatible with hbmqtt's API. Can you point me somewhere to fix it?

Edit: Nevermind, I forgot to uncomment a bunch of code, my bad!

👉️ it works! Even with Python 3.9! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants