Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsolete partials? #82

Open
cdmo opened this issue Jun 6, 2019 · 0 comments
Open

Obsolete partials? #82

cdmo opened this issue Jun 6, 2019 · 0 comments

Comments

@cdmo
Copy link
Member

cdmo commented Jun 6, 2019

It seems to me _endnote.html.erb is obsolete because of how document action links are now handled in Blacklight. _show_tools.html.erb basically just takes the content of endnote and refworks and does a link_to on them inside of a uniform li. Wondering if _endnote.html.erb, _marc_tools.html.erb and _refworks.html.erb should be deleted (i.e., blacklight-marc/app/views/bookmarks)? Or do they still serve a purpose I'm not seeing?

This has come up for me because I'm trying to override in a way that is copacetic to blacklight and blacklight_marc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant