Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify terms query #19

Open
awead opened this issue Jun 9, 2016 · 2 comments
Open

Simplify terms query #19

awead opened this issue Jun 9, 2016 · 2 comments

Comments

@awead
Copy link
Contributor

awead commented Jun 9, 2016

Instead of:
({!terms f=discover_access_group_ssim}public) OR ({!terms f=read_access_group_ssim}public)
do something like:
({!terms f=discover_access_group_ssim v=$groups}) OR ({!terms f=read_access_group_ssim v=$groups})&groups=public

kudos to @erikhatcher for pointing this out in #17

@atz
Copy link
Member

atz commented Sep 1, 2016

Interesting. Wouldn't call this simplification, though. In particular because we need the clauses to be atomic since they are aggregated and crudely OR'd together.

@erikhatcher
Copy link

Wouldn't call this simplification, however.

It's DRYer though :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants