Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

error handling in dll #213

Open
CarolineMathieson opened this issue Aug 23, 2018 · 1 comment
Open

error handling in dll #213

CarolineMathieson opened this issue Aug 23, 2018 · 1 comment
Assignees

Comments

@CarolineMathieson
Copy link

When calling any of the FFI_mitls_configure_xxx functions to configure cipher suites, signature algorithms or named groups, the functions are very sensitive to the precise names used to specify the values. Since these are passed by name, the exact name must be used. When there is a slight error, the dll typically crashes the application using the dll without providing any error message. So your application just disappears without warning.

Error handling needs to be improved so that in this situation, an error indication is given and the function should just return 0 as the other API functions do.

@ad-l
Copy link
Contributor

ad-l commented Aug 31, 2018

Agreed it's a problem. The configuration functions currently can't return errors

@ad-l ad-l self-assigned this Aug 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants