Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

Test is not run in the MSVC configuration #212

Open
msprotz opened this issue Aug 14, 2018 · 8 comments
Open

Test is not run in the MSVC configuration #212

msprotz opened this issue Aug 14, 2018 · 8 comments

Comments

@msprotz
Copy link
Member

msprotz commented Aug 14, 2018

https://github.com/project-everest/mitls-fstar/blob/master/src/windows/quiccrypto/makefile.vs#L22

this line doesn't work; I don't know how to do this in a visual studio makefile, short of calling into a .bat script; would anyone know how to make this work? @wintersteiger perhaps?

@wintersteiger
Copy link
Contributor

wintersteiger commented Aug 14, 2018

Use & instead of ;?

E.g. compare set PATH=..\kremlib;%PATH% ; echo %PATH% with set PATH=..\kremlib;%PATH% & echo %PATH%

@msprotz
Copy link
Member Author

msprotz commented Aug 14, 2018

D:\cygwin\home\protz\Code\mitls-fstar\src\windows\quiccrypto>nmake -f makefile.vs

Microsoft (R) Program Maintenance Utility Version 14.10.25017.0
Copyright (C) Microsoft Corporation.  All rights reserved.

        set PATH=..\kremlib;..\evercrypt;%PATH% & .\test.exe

D:\cygwin\home\protz\Code\mitls-fstar\src\windows\quiccrypto>

nothing seems to run... any clue how to diagnose this?

@wintersteiger
Copy link
Contributor

Does it pop up any dialogs in the background saying that it didn't find DLL so and so?

@msprotz
Copy link
Member Author

msprotz commented Aug 14, 2018

On my machine, when I copy/paste that line, it displays some output then fails with an illegal instruction error. Nothing shows up when this is executed via the Makefile...

@wintersteiger
Copy link
Contributor

wintersteiger commented Aug 14, 2018

Right, it probably suppresses that for some reason. Maybe wrap it in cmd /c "..."?

@wintersteiger
Copy link
Contributor

I can't run that makefile, it complains that it doesn't know how to produce .obj files... I assume that's expected?

@wintersteiger
Copy link
Contributor

Aha! Yes, the set doesn't work properly when used like that, the call to test.exe will see the old path.

@wintersteiger
Copy link
Contributor

Try this:

test: test.exe libquiccrypto.dll
	set PATH=..\kremlib;%PATH%
	echo PATH=%%PATH%%
	.\test.exe

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants