Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitsum: try removing positivity constraint on key_size #39

Open
tahina-pro opened this issue Jan 14, 2021 · 1 comment
Open

bitsum: try removing positivity constraint on key_size #39

tahina-pro opened this issue Jan 14, 2021 · 1 comment
Assignees
Labels
lowparse The LowParse verified parsing and serialization combinator library

Comments

@tahina-pro
Copy link
Member

tahina-pro commented Jan 14, 2021

(key_size: nat { key_size > 0 /\ key_size <= bitsum'_size /\ bitsum'_size <= tot }) -> // key_size made positive because F* cannot prove that (payload _) is a smaller term wrt. << without FStar.WellFounded.axiom1_dep //NS: TODO: please check this comment

Thank you @nikswamy for pointing this out. For now I will leave it as is, for the sake of merging your changes into master, CI permitting.
Later I will separately investigate whether I can remove that restriction on key_size, and if not, I will update the comment accordingly.

Originally posted by @tahina-pro in #38 (comment)

@tahina-pro tahina-pro added the lowparse The LowParse verified parsing and serialization combinator library label Jan 14, 2021
@tahina-pro
Copy link
Member Author

I hope this constraint can be lifted thanks to FStarLang/FStar#2205, which should allow me to correctly perform structural recursion on bitsum_t

@tahina-pro tahina-pro self-assigned this Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lowparse The LowParse verified parsing and serialization combinator library
Projects
None yet
Development

No branches or pull requests

1 participant