Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImgUI UI should switch to DataModel::Provider instead of Accessors #37178

Open
andy31415 opened this issue Jan 23, 2025 · 0 comments
Open

ImgUI UI should switch to DataModel::Provider instead of Accessors #37178

andy31415 opened this issue Jan 23, 2025 · 0 comments

Comments

@andy31415
Copy link
Contributor

Using Accessorts ties things to ember and also prevents usage of AttributeAccessInterface.

See usage of Accessors in

https://github.com/project-chip/connectedhomeip/blob/master/examples/common/imgui_ui/windows

For example https://github.com/project-chip/connectedhomeip/blob/master/examples/common/imgui_ui/windows/light.cpp#L100

All Attributes Get and Set should be replaced with DataModel::Provider ReadAttribute and WriteAttribute. We likely want some shared code for most of this as we get/set common types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant