Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iron Chests unintentionally adds non-chest textures from other mods to the chest atlas #320

Open
XFactHD opened this issue Sep 21, 2024 · 0 comments

Comments

@XFactHD
Copy link

XFactHD commented Sep 21, 2024

Version Information

Minecraft: 1.21.1
NeoForge: 21.1.54
Iron Chests: 16.0.7

Report Information

Iron Chests uses a DirectoryLister sprite source to add its chest textures to the chest atlas. The default DirectorySource is not namespaced, which means that any texture in the specified directory or subdirectory thereof gets added, regardless of the texture's namespace. Since the textures/models/ directory is often used for large texture maps used by "entity" models which are rendered by entity renderers or BERs and which are not intended to be stitched to an atlas, this causes the chest atlas to be bloated by these unnecessary textures. In 1.21.1 this can be fixed by using the NamespacedDirectoryLister provided by NeoForge since 21.1.29 instead. In earlier versions, this custom sprite source needs to either be implemented manually or the individual textures added by a SingleFile sprite source per texture.

Steps to Reproduce

  1. Install Iron Chests together with a mod that adds its own textures in textures/models/ (i.e. Modular Force Field Systems)
  2. Inspect the chest atlas with vanilla's atlas dump keybind (F3 + S) or AtlasViewer (the latter includes information about which resource pack contains the sprite source adding a given texture)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant