Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] Reorganize the CSS rules #72

Open
tbouffard opened this issue Oct 24, 2022 · 0 comments
Open

[REFACTOR] Reorganize the CSS rules #72

tbouffard opened this issue Oct 24, 2022 · 0 comments

Comments

@tbouffard
Copy link
Member

tbouffard commented Oct 24, 2022

This particularly applies to Happy Path rules but review all css rules.

happy-path rules
There is no need to declare class by types. The CSS classname should always be the same and the CSS rule should required both the BPMN CSS classes and the specific classes. For intance bpmn-type-activity.happy-path

The from/to stroke are not needed in the animation if the grow keyframes (same values for from and to), if the value was correctly set in the CSS rule referencing this keyframes declaration

@keyframes grow {
from {
stroke-dashoffset: 100%;
stroke-dasharray: 100%;
stroke: var(--stroke);
stroke-width: var(--stroke-width);
fill: var(--fillStart);
}
to {
stroke-dashoffset: 0;
stroke: var(--stroke);
stroke-width: var(--stroke-width);
fill: var(--fillEnd);
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant