Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render_combined implicitly relies on axis limits being the same for x and y axis. #13

Open
Schaechtle opened this issue Feb 11, 2019 · 0 comments

Comments

@Schaechtle
Copy link
Collaborator

Schaechtle commented Feb 11, 2019

For an exercise in section 5, we request the user to do construct their own dataset and then render it with render_combined, which relies on render_trace and render_sine_trace. Both functions run:

ax[:set_ylim]((xmin, xmax))

If a user constructs a dataset where x and y axis limits don't agree, it won't be plotted fully (or at all).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant