Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue in lint-staged pre-commit hook #104

Open
mbehzad opened this issue Apr 9, 2021 · 0 comments
Open

issue in lint-staged pre-commit hook #104

mbehzad opened this issue Apr 9, 2021 · 0 comments

Comments

@mbehzad
Copy link
Contributor

mbehzad commented Apr 9, 2021

From package.json in root

"lint-staged": {
    "*.ts": [
      "lint"
    ]
  },
  • projects code is written in .js so the glob pattern probably should be for ".js" (or both extensions for future code (e.g. vscode-pv-handlebars-languag PR))
  • there is no executable "lint" in the npm dependencies. probably eslint was meant here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant