Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update dependabot workflow to add commit message and label #1812

Closed
3 tasks done
Anmol-Baranwal opened this issue Jul 23, 2023 · 4 comments
Closed
3 tasks done
Labels
⛔️ status: discarded Will not be worked on

Comments

@Anmol-Baranwal
Copy link
Contributor

what's wrong with the documentation?

Current One:

version: 2
updates:
  - package-ecosystem: 'npm'
    directory: '/'
    schedule:
      interval: 'daily'

Firstly, it should have a proper commit prefix according to conventions, such as chore(deps). Additionally, it lacks a label, which could be helpful for someone looking at the PR, like 📦 dependencies.

Add screenshots

looks clean and according to conventions
image

Record

  • I agree to follow this project's Code of Conduct
  • I'm a GSSoC'23 contributor
  • I want to work on this issue
@Anmol-Baranwal Anmol-Baranwal added good first issue New-contributor friendly ✨ goal: improvement Improvement to an existing feature 📄 aspect: text Concerns the textual material in the repository 🚦status: awaiting triage Has not been triaged & therefore, not ready for work 🟨 priority: medium Not blocking but should be fixed soon labels Jul 23, 2023
@github-actions
Copy link

To reduce notifications, issues are locked. Your issue will be unlock when we will add label as 🏁 status: ready for dev. Check out the contributing guide for more information. Also, if you're in GSSoC'23 please check the discussion

@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2023
Repository owner unlocked this conversation Jul 23, 2023
@priyankarpal priyankarpal added ⛔️ status: discarded Will not be worked on and removed 📄 aspect: text Concerns the textual material in the repository good first issue New-contributor friendly ✨ goal: improvement Improvement to an existing feature 🟨 priority: medium Not blocking but should be fixed soon 🚦status: awaiting triage Has not been triaged & therefore, not ready for work labels Jul 23, 2023
@priyankarpal
Copy link
Owner

hey @Anmol-Baranwal I think this issue is not related to solving documentation, so please use blank issue template in future.

  • I think we don't need to add/change any thing for dependabot configaration. Now you can see the screenshot where dependabot already added dependencies label & also added good prefix chore(dep):

image

Closed dependabot PRs

https://github.com/priyankarpal/ProjectsHut/pulls?q=is%3Apr+author%3Aapp%2Fdependabot+is%3Aclosed

@priyankarpal priyankarpal closed this as not planned Won't fix, can't repro, duplicate, stale Jul 23, 2023
@Anmol-Baranwal
Copy link
Contributor Author

Sure, maybe I didn't notice properly.

Also workflows are considered as a part of documentation. Because when we add a workflow, we use docs. Correct me if I am wrong.

@priyankarpal
Copy link
Owner

Sure, maybe I didn't notice properly.

Also workflows are considered as a part of documentation. Because when we add a workflow, we use docs. Correct me if I am wrong.

for CI/CD we have to use ci: title the format. You can check the documentation https://www.conventionalcommits.org/en/v1.0.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⛔️ status: discarded Will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants