Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent Text Selection In Landing Page #1799

Closed
3 tasks done
Souravvmishra opened this issue Jul 22, 2023 · 9 comments · Fixed by #1881
Closed
3 tasks done

Prevent Text Selection In Landing Page #1799

Souravvmishra opened this issue Jul 22, 2023 · 9 comments · Fixed by #1881
Assignees
@Souravvmishra
Labels
💻 aspect: code Concerns the software code in the repository ⭐ goal: addition Addition of new feature gssoc23 only for Girlscript summer of code level1 small level fix for GSSoC 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for dev Ready for work

Comments

@Souravvmishra
Copy link
Contributor

What feature?

In the landing page, cards get a sort of border on hover state but in Mobile devices, Hover work on long tap or click but on clicking the card, the text get selected which opens the google translate for the word which is sort of so annoying.

The idea is to prevent text selection in these cards.

Add screenshots

Uploading Screenshot_2023-07-22-14-09-02-771-edit_com.android.chrome.jpg…

Record

  • I agree to follow this project's Code of Conduct
  • I'm a GSSoC'23 contributor
  • I want to work on this issue
@Souravvmishra Souravvmishra added ⭐ goal: addition Addition of new feature 🚦status: awaiting triage Has not been triaged & therefore, not ready for work labels Jul 22, 2023
@github-actions
Copy link

To reduce notifications, issues are locked. Your issue will be unlock when we will add label as 🏁 status: ready for dev. Check out the contributing guide for more information. Also, if you're in GSSoC'23 please check the discussion

@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2023
Repository owner unlocked this conversation Jul 23, 2023
@priyankarpal
Copy link
Owner

could you share a demo?

@priyankarpal priyankarpal added ❓ talk: question Further information is requested and removed 🚦status: awaiting triage Has not been triaged & therefore, not ready for work labels Jul 23, 2023
@Souravvmishra
Copy link
Contributor Author

Sure, Give me some time.
This would just require preventing the text selection so that, it doesn't select the text which in turn would prevent opening the google.

@priyankarpal
Copy link
Owner

could you share update on this issue?

@Souravvmishra
Copy link
Contributor Author

I'm a little busy. Will update you as soon as possible

@Souravvmishra
Copy link
Contributor Author

I can't find a way to show you this thing here. should i make the pr and then you can see this live in action in preview

@priyankarpal
Copy link
Owner

priyankarpal commented Jul 27, 2023 •
edited
Loading

I can't find a way to show you this thing here. should i make the pr and then you can see this live in action in preview

you can share a screen recording

@Souravvmishra
Copy link
Contributor Author

check discord

@priyankarpal
Copy link
Owner

assigned

@priyankarpal priyankarpal added 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for dev Ready for work gssoc23 only for Girlscript summer of code level1 small level fix for GSSoC 💻 aspect: code Concerns the software code in the repository and removed ❓ talk: question Further information is requested labels Jul 29, 2023
@priyankarpal priyankarpal linked a pull request Jul 29, 2023 that will close this issue
chore: Prevent Text Selection #1881
Merged
@priyankarpal priyankarpal mentioned this issue Jul 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Souravvmishra Souravvmishra

Labels
💻 aspect: code Concerns the software code in the repository ⭐ goal: addition Addition of new feature gssoc23 only for Girlscript summer of code level1 small level fix for GSSoC 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for dev Ready for work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Prevent Text Selection Souravvmishra/ProjectsHut
2 participants
@priyankarpal @Souravvmishra