Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Is it OK to not support previous VerifyingKey versions? #267

Open
ed255 opened this issue Feb 2, 2024 · 0 comments
Open

Discussion: Is it OK to not support previous VerifyingKey versions? #267

ed255 opened this issue Feb 2, 2024 · 0 comments

Comments

@ed255
Copy link
Member

ed255 commented Feb 2, 2024

From here:

if VERSION != version_byte[0] {

In halo2, whenever an update changes the VeriyingKey type in a non forward-compatible manner we're supposed to bump the version. When reading a serialized VerifyingKey, older versions are rejected.

I think supporting multiple versions could add a lot of complexity, but we can discuss this.

Discussion from #254 (comment)

@ed255 ed255 mentioned this issue Feb 2, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant