From 20c12903d29f9635b0b24f8b35842a9cefabf7ad Mon Sep 17 00:00:00 2001 From: Huulu <35667132+IssouChancla@users.noreply.github.com> Date: Wed, 20 Dec 2023 10:01:39 +0100 Subject: [PATCH] chore: correcting few mistakes in documentation (#240) * typo fix * typo fix * typo fix --- book/src/background/curves.md | 4 ++-- book/src/user/experimental-features.md | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/book/src/background/curves.md b/book/src/background/curves.md index 2600127ddf..089ff77fff 100644 --- a/book/src/background/curves.md +++ b/book/src/background/curves.md @@ -105,7 +105,7 @@ $$ Our original curve is just this curve at the restriction $Z = 1$. If we allow the affine point $(x, y)$ to be represented by $X = xZ$, $Y = yZ$ and $Z \neq 0$ then we have the -[homogenous projective curve](https://en.wikipedia.org/wiki/Homogeneous_coordinates) +[homogeneous projective curve](https://en.wikipedia.org/wiki/Homogeneous_coordinates) $$ Y^2 Z = X^3 + Z^3 b. @@ -185,7 +185,7 @@ Important notes: $(x, y) = (xZ^2, yZ^3, Z)$ where the curve is rescaled by $Z^6$ instead of $Z^3$, and this representation has even more efficient arithmetic but no unified/complete formulae. * We can easily compare two curve points $(X_1, Y_1, Z_1)$ and $(X_2, Y_2, Z_2)$ for - equality in the homogenous projective coordinate space by "homogenizing" their + equality in the homogeneous projective coordinate space by "homogenizing" their Z-coordinates; the checks become $X_1 Z_2 = X_2 Z_1$ and $Y_1 Z_2 = Y_2 Z_1$. ## Curve endomorphisms diff --git a/book/src/user/experimental-features.md b/book/src/user/experimental-features.md index 3ef73c482c..78ea802ce4 100644 --- a/book/src/user/experimental-features.md +++ b/book/src/user/experimental-features.md @@ -55,7 +55,7 @@ It allows us to allocate advice column in different interactive phases with extr ### Unblinded advice column -[`ConstraintSystem::unblinded_advice_column`](https://privacy-scaling-explorations.github.io/halo2/halo2_proofs/plonk/struct.ConstraintSystem.html#method.unblinded_advice_column) is added for use cases that want to re-use advice column commitment among different proofs. For example in `halo2_proofs/examples/vector-ops-unblinded.rs` it shows with this API and same assignment, two advice commitment frmo different proof can be same. +[`ConstraintSystem::unblinded_advice_column`](https://privacy-scaling-explorations.github.io/halo2/halo2_proofs/plonk/struct.ConstraintSystem.html#method.unblinded_advice_column) is added for use cases that want to reuse advice column commitment among different proofs. For example in `halo2_proofs/examples/vector-ops-unblinded.rs` it shows with this API and same assignment, two advice commitment from different proof can be same. Worth mentioning, re-using advice column commitment in different proofs will need more blinding factors than the amount that prover adds, otherwise some information will be leaked and it's no longer perfect zero-knowledge.