Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue in translating "en" to "en" #2

Open
ghost opened this issue Feb 6, 2017 · 2 comments
Open

Issue in translating "en" to "en" #2

ghost opened this issue Feb 6, 2017 · 2 comments

Comments

@ghost
Copy link

ghost commented Feb 6, 2017

HI
When i giving same language for translation for source and target it is not doing translation

params.source = fromLanguage.text ?? "fr"
params.target = toLanguage.text ?? "fr"

Can you please advise on this

THanks

@prine
Copy link
Owner

prine commented Feb 6, 2017

Hello

Yeah this is the google api which is returning a 400 "Bad Request" for having the same source and target language. Why would you translate into the same language :)? Is there any use of that?

But you're right. Better error handling would be useful. So it's clear if its a API Error or not..

Cheers

@ghost
Copy link
Author

ghost commented Feb 6, 2017

Thanks for reply

Some translator app have this functionality ( though as you said not very useful) , so i think as i would need to add a alert if user tries to do something like this so that it becomes clear to the user that app wont allow this otherwise they might consider that there is some issue with app

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant