Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable row selection slow on larger tables #7056

Open
2 of 4 tasks
Shin-- opened this issue Jan 8, 2025 · 1 comment
Open
2 of 4 tasks

DataTable row selection slow on larger tables #7056

Shin-- opened this issue Jan 8, 2025 · 1 comment
Labels
Resolution: Help Wanted Issue or pull request requires extra help and feedback
Milestone

Comments

@Shin--
Copy link

Shin-- commented Jan 8, 2025

Describe the bug

When rendering a DataTable that has more than a few columns or a larger amount of rows, it leads to slow rendering of the DataTable and very slow responding checkboxes when selecting a row. The underlying issue seems to be that a row selection re-renders the whole table, and the rendering itself being slow.

Screenshot 2025-01-08 at 09 44 33

I assume the re-render of the whole table when selecting a row is a bug. Possibly related to #5309

Pull Request Link

No response

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://stackblitz.com/edit/ui2jyp9p-v9bun1mf

Environment

Vue version

3.5

PrimeVue version

4.2.x

Node version

No response

Browser(s)

No response

Steps to reproduce the behavior

Create any table with row selection. As soon as there are around 1000 cells (height * width) the delay between click and selection becomes very noticable.

Expected behavior

Row-selection feels instantaneous and there is no re-rendering of all cells in the row, let alone all rows, necessary.

@Shin-- Shin-- added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 8, 2025
@tugcekucukoglu tugcekucukoglu added Resolution: Help Wanted Issue or pull request requires extra help and feedback and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 20, 2025
@tugcekucukoglu tugcekucukoglu added this to the Future milestone Jan 20, 2025
@github-project-automation github-project-automation bot moved this to Review in PrimeVue Jan 20, 2025
Copy link

Due to PrimeTek's demanding roadmap for PrimeVue and the limited bandwidth of the core team, this issue is available for anyone to work on. Make sure to reference this issue in your pull request. ✨ Thank you for your contribution! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Help Wanted Issue or pull request requires extra help and feedback
Projects
Status: Review
Development

No branches or pull requests

2 participants