Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: Form Components Theme: inconsistent invalid fields hover border color #17162

Open
honboubao opened this issue Dec 20, 2024 · 2 comments
Assignees
Labels
Component: Theme Issue or pull request is related to Theme Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@honboubao
Copy link
Contributor

Describe the bug

Various form components behave differently in regards to the displayed border style, when the fields have the .ng-invalid.ng-dirty CSS classes applied and when they are hovered over at the same time.

Some will display the --p-form-field-invalid-border-color (e.g. pInputText, p-select, p-autocomplete with multiple, checkbox, radiobox} while some will display --p-form-field-hover-border-color.

Environment

Windows 10
Firefox 128.3.1esr

Reproducer

https://stackblitz.com/edit/stackblitz-starters-6nsm3jzl?file=src%2Fapp%2Fapp.component.html

Angular version

18

PrimeNG version

18

Node version (for AoT issues node --version)

No response

Browser(s)

No response

Steps to reproduce the behavior

  1. Include various form components
  2. make components invalid, e.g. by adding ng-invalid and ng-dirty CSS classes
  3. hover over components
  4. observe the rendered border color

Expected behavior

You could argue for either one, displaying the invalid color or the hover color. I personally would rather keep the invalid color on hover. Either way, all the components should behave in a single consistent way.

@honboubao honboubao added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 20, 2024
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 25, 2024
@mertsincan mertsincan added this to the 19.x milestone Dec 25, 2024
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Dec 25, 2024
@mertsincan mertsincan added the Status: Discussion Issue or pull request needs to be discussed by Core Team label Dec 25, 2024
@mertsincan mertsincan changed the title Component: Form Components Theme: inconsistent invalid fields hover border color (v18.0.2) Component: Form Components Theme: inconsistent invalid fields hover border color Dec 25, 2024
@honboubao
Copy link
Contributor Author

I just want to add, that the focused and probably disabled style plays into this as well. So focused, hover and invalid and disabled border styles should be ranked by precedence and applied consistently to all components.

@mertsincan mertsincan moved this from Review to Theme in PrimeNG Jan 15, 2025
@mertsincan mertsincan added the Component: Theme Issue or pull request is related to Theme label Jan 15, 2025
@mertsincan mertsincan modified the milestones: 19.x, 19.1.0 Jan 15, 2025
@cagataycivici cagataycivici modified the milestones: 19.1.0, 19.0.6 Jan 25, 2025
@cagataycivici
Copy link
Member

v19.1.0 will use the new shared theme package that all other Prime libs will be using, this issue is from an inconsistency due to port from the Vue version. Will be fixed via v19.1.0 after the migration.

https://github.com/primefaces/primeuix/tree/main/packages/themes

@cagataycivici cagataycivici added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team Status: Discussion Issue or pull request needs to be discussed by Core Team labels Feb 5, 2025
@cagataycivici cagataycivici modified the milestones: 19.0.6, 19.1.0 Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Theme Issue or pull request is related to Theme Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
Status: Theme
Development

No branches or pull requests

3 participants