You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since expiring_url is from Paperclip (I assume) and isn't likely to be confused with an attacker-controllable value, I think it's fine to have Brakeman ignore expiring_url.
Easy enough to add to the ignore file, but if it's possible to detect this as safe (perhaps because the parameter in question is only being used as the input to an ActiveRecord query and not a bare part of the redirect? honestly not sure if that matters or would be detectable) that'd be a welcome change.
Brakeman version: 5.2.1
Rails version: 6.1.4.6
Ruby version: 3.1.0
I am having this result for an url that allows user to download a document.
Confidence: High
Category: Redirect
Check: Redirect
Message: Possible unprotected redirect
Code: redirect_to(Classified.find(params[:id]).documents.find(params[:document_id]).asset.expiring_url(10))
File: ******_controller.rb
An issue has already been opened for this.
Should we still avoid the warning or is there any chance for the warning to be changed as here?
The text was updated successfully, but these errors were encountered: