Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python tests should allow custom requirements #1168

Open
hadim opened this issue Nov 7, 2024 · 1 comment · May be fixed by #1170
Open

Python tests should allow custom requirements #1168

hadim opened this issue Nov 7, 2024 · 1 comment · May be fixed by #1170

Comments

@hadim
Copy link
Contributor

hadim commented Nov 7, 2024

I think the python tests should allow custom deps spec. For example, in this feedstock I need to set the python version of a noarch package and it is not allowed:

tests:
  - python:
      imports:
        - pptx
      requirements:
        run:
          - python =${{ python_min }}

so I had to replace it with:

tests:
  - script:
      - python -c "import pptx"
    requirements:
      run:
        - python =${{ python_min }}

What do you think is the best way to address this?

  1. allow requirements or requirements.run?
  2. add python_version so only the python version can be customized?

Let me know, what you think is best here and I can submit a PR if you want.

@hadim
Copy link
Contributor Author

hadim commented Nov 7, 2024

@hadim hadim linked a pull request Nov 7, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant