You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
tests:
- script:
- if: unixthen:
- test ! -f ${PREFIX}/lib/libz.a
- test ! -f ${PREFIX}/lib/libz${SHLIB_EXT}
- test ! -f ${PREFIX}/include/zlib.helse:
- if not exist %LIBRARY_BIN%\zlib.dll exit 1
- if not exist %PREFIX%\zlib.dll exit 1
During the build (logs) on windows, we see that the file we're testing for is definitely there,
│ │ │ (base) %SRC_DIR%>if not exist D:\bld\bld\rattler-build_libzlib_1730506967\work\test\Library\bin\zlib.dll exit 1
│ │ │ × error Script failed with status 1
I understand that the positive tests can be formulated as
tests:
- package_contents:
files:
but what worries me far more is that anything under tests: scripts: produces false positives or negatives. If we can't trust that correctly specified, benign-looking tests are executed correctly (and doubly so if they're working under conda-build), we're blocked from migrating at scale.
The text was updated successfully, but these errors were encountered:
h-vetinari
changed the title
Some tests using scripts: non-functional (both false positive & false negatives)
BUG: Some tests using scripts: non-functional on windows
Nov 2, 2024
I am not sure I understand. You want to test that zlib.dll is NOT there?
Would you be able to make a small reproducer? Are you sure that your condition is correct in the windows test? It looks to me like you are testing the inverse of the unix tests here (on one you test for non-existence, and on the other for existence).
We are just executing the script as given, with a few env vars. No big magic involved :)
There are situations where the
package_contents
tests are not applicable (especially because file exclusion isn't implemented yet).In conda-forge/zlib-feedstock#83, I currently have
During the build (logs) on windows, we see that the file we're testing for is definitely there,
but the test fails
I understand that the positive tests can be formulated as
but what worries me far more is that anything under
tests: scripts:
produces false positives or negatives. If we can't trust that correctly specified, benign-looking tests are executed correctly (and doubly so if they're working underconda-build
), we're blocked from migrating at scale.The text was updated successfully, but these errors were encountered: