-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bad Input Error if pbjs s2s config contains alias configuration for a disabled adapter #3592
Bad Input Error if pbjs s2s config contains alias configuration for a disabled adapter #3592
Comments
I guess I had hoped that this sort of situation would have been addressed by prebid/prebid-server#3735, but that issue was more about imp.ext, and didn't deal with aliases clearly enough. So yes, I'm supportive of changing the disabled bidder behavior in general. Fail-Fast has shown itself to be a little too draconian in the edge cases. Proposal A: Never hard fail on an unknown bidder. Just warn and log a metric. This would solve this problem and probably other edge-cases. Proposal B: Never hard fail on a bidder that exists but is not enabled. Just warn and log a metric. Does PBS even have this info? |
…nfiguration for a disabled adapter
…nfiguration for a disabled adapter
Deploying
alias
configurations for prebid server through prebid.js is dangerous, because if a bidder is being disabled, it can stop the entire monetization of prebid server. Disabled bidders will stop the entire bid requests with a400
if the alias configuration contains a disabled bidder.🪄 Steps to reproduce
Prebid.js
s2s
configand send a request to a prebid server where
BidderC
is not enabled.This will cause a
400
with💡 Proposal
We turn the 400 into an error metric. Related to #3209
Related
If the bidder being alias is unknown also a
400
is being returned:which I guess is okaish, but a metric would also be better.
The text was updated successfully, but these errors were encountered: