Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdViewUtils.findPrebidCreativeSize pollutes logcat with an unnecessary warning when no size object found #725

Open
justadreamer opened this issue Dec 12, 2023 · 2 comments

Comments

@justadreamer
Copy link

justadreamer commented Dec 12, 2023

Describe the bug
If Prebid creative loses and some other creative served AdViewUtils.findPrebidCreativeSize would fail to find hb_size:<size> in the creative and would log a warning:

errorCode:240 errorDescription:The HTML doesn't contain a size object

The logging happens here.

However this is not an error per se - the creative may or may not contain hb_size. If it does not contain a size object - it simply means it is not a Prebid Universal Creative. Thus it should be at max an info level message, not a warning level and it should read: The HTML does not appear to be a Prebid Universal Creative, as it does not contain an hb_size snippet.

To Reproduce
Steps to reproduce the behavior:

  1. Load and render any banner creative (a test ad in Google Mobile Ads SDK would do) that would be not a universal creative
  2. Call AdViewUtils.findPrebidCreativeSize on the bannerView
  3. Observe a warning message logged

Expected behavior
The info level message as suggested above is logged.

Screenshots
image

Smartphone (please complete the following information):
Any Android.

@jsligh
Copy link
Collaborator

jsligh commented Jun 3, 2024

@justadreamer is this still an issue?

@justadreamer
Copy link
Author

Hi @jsligh yes this is still an issue, but very minor (cosmetics), can be handled with low priority.

@jsligh jsligh self-assigned this Jun 5, 2024
@jsligh jsligh removed their assignment Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for Dev
Development

No branches or pull requests

2 participants