Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.nvmrc node version (18) isn't aligned with the one inside the docker image (14.2.0) #273

Open
silicakes opened this issue May 15, 2023 · 1 comment
Open

.nvmrc node version (18) isn't aligned with the one inside the docker image (14.2.0) #273

silicakes opened this issue May 15, 2023 · 1 comment

Comments

@silicakes
Copy link

Before submitting the PR, should we consider bumping the image version to 18.16 (LTS)? or should we pull .nvmrcs version down?

(I prefer the former).
@goldbergyoni
Copy link
Contributor

goldbergyoni commented May 18, 2023 •
edited
Loading

Let's upgrade both .nvmrc to 18.16 💜, and docker of course

Just ensure that the tests pass

@silicakes

silicakes added a commit to silicakes/practica that referenced this issue May 18, 2023
@silicakes
273: Upgrade docker image to 18.16 (LTS)
3adc087 
This PR aligns the versions of nodejs throughout the project
(.nvmrc/Dockerfile)

Issue: practicajs#273
@silicakes silicakes mentioned this issue May 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@silicakes @goldbergyoni