Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS home indicator obstructs components behind it #31387

Open
frenzibyte opened this issue Jan 2, 2025 · 2 comments
Open

iOS home indicator obstructs components behind it #31387

frenzibyte opened this issue Jan 2, 2025 · 2 comments

Comments

@frenzibyte
Copy link
Member

We apply an override to bottom edge safe area in OsuGameIOS, making the game extend to the home indicator. This causes the home indicator to obstruct components behind it, such as song select footer buttons or chat overlay text box etc.

Simulator Screenshot - iPhone 16 - 2025-01-02 at 03 13 59
Simulator Screenshot - iPhone 16 - 2025-01-02 at 03 14 02
Simulator Screenshot - iPhone 16 - 2025-01-02 at 03 21 34

The initial goal was to add extensive handling of safe area so the home indicator gets its own space without just a black box surrounding it, but further discussions halted this approach pending proper direction from the design team first so the final result does not look awkward.

One temporary direction here is to remove the override and make this user toggleable similar to the horizontal edges. Preview without the override, aka "letterbox":

Simulator Screenshot - iPhone 16 - 2025-01-02 at 03 32 08
Simulator Screenshot - iPhone 16 - 2025-01-02 at 03 32 12
Simulator Screenshot - iPhone 16 - 2025-01-02 at 03 32 20

@frenzibyte
Copy link
Member Author

cc @peppy

@frenzibyte
Copy link
Member Author

Also cc @ppy/team-design for commentary on the screenshots above and how to better fill the black gap around the home indicator in the second batch of screenshots so it doesn't look silly like it is right now. There are other areas to discuss as well but let's start with the above first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant