Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3: Refactor OptRepo interfaces, merging with the Opt access services #1069

Open
ppazos opened this issue Mar 4, 2020 · 1 comment
Open
Assignees

Comments

@ppazos
Copy link
Owner

ppazos commented Mar 4, 2020

  1. Make the services implement the Opt repo interface (this is to merge all the methods from OptRepositoryS3Impl and OptRepositoryFSImpl into the OptS3Service and OptFSService)
  2. Move the correspondent methods from the current repo impl
  3. Delete the repo impls
  4. Test everything works OK
@ppazos ppazos self-assigned this Mar 4, 2020
@ppazos
Copy link
Owner Author

ppazos commented Mar 21, 2020

The issue with this is: services are injected so the config changes the services and we don't need to do anything extra, but we have a factory for OptRepositoryS3Impl and OptRepositoryFSImpl, so moving the methods to the services needs to remove the factory. Another issue is we are passing those repos as parameters to some functions, if we move everything to the services, we need to inject the services in the correspondent classes and avoid passing any parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant