You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Make the services implement the Opt repo interface (this is to merge all the methods from OptRepositoryS3Impl and OptRepositoryFSImpl into the OptS3Service and OptFSService)
Move the correspondent methods from the current repo impl
Delete the repo impls
Test everything works OK
The text was updated successfully, but these errors were encountered:
The issue with this is: services are injected so the config changes the services and we don't need to do anything extra, but we have a factory for OptRepositoryS3Impl and OptRepositoryFSImpl, so moving the methods to the services needs to remove the factory. Another issue is we are passing those repos as parameters to some functions, if we move everything to the services, we need to inject the services in the correspondent classes and avoid passing any parameters.
The text was updated successfully, but these errors were encountered: