Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract core resource methods to a base class. #264

Closed
tdstein opened this issue Sep 4, 2024 · 1 comment
Closed

Abstract core resource methods to a base class. #264

tdstein opened this issue Sep 4, 2024 · 1 comment
Labels
enhancement New feature or request sdk Used for automation

Comments

@tdstein
Copy link
Collaborator

tdstein commented Sep 4, 2024

Currently, each resource implementation defines the same methods when available (find, find_one, create, etc.). Initially, it didn't make sense to abstract these methods into a base class since it wasn't clear how much overlap existed. But now, it's obvious that a majority of implementations between API endpoints are identical. In cases where endpoints differ, the subclass should override the base class. When the method is not supported a NotImplementedError should be raised and the method should be documented as such.

@tdstein tdstein added the enhancement New feature or request label Sep 4, 2024
@tdstein tdstein added the sdk Used for automation label Sep 13, 2024
@tdstein
Copy link
Collaborator Author

tdstein commented Nov 13, 2024

The core components of this feature were introduced in #314

We will continue adding this functionality during development of other API endpoints.

@tdstein tdstein closed this as completed Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request sdk Used for automation
Projects
None yet
Development

No branches or pull requests

1 participant