You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
because there is no longer anything it can send messages to.
The tower-lsp server will exit like this during a Positron developer refresh, so it is a decently common case. I think it is possible for us to get in a bad place if we don't clear the RMain sender.
The text was updated successfully, but these errors were encountered:
If we solve the issue of zombie extension hosts, it would also be good to detect whether an LSP is already running on comm_open. That would be an error as the client should first shut down the LSP.
Unfortunately comm_open is a notification, not a request, so there is no straightforward way of propagating the error. We might want to extend this message and allow it to be a request if a field is set. This would be advertised as a kernel capability and allow the client to wait for a result and know for sure whether an LSP was started.
lionel-
changed the title
Clear events_tx in RMain on LSP shutdown
Improve lifecycle management of LSP
Nov 8, 2024
@lionel- and I were looking at the LSP lifecycle a little more and realized that when the tower-lsp server exits here:
ark/crates/ark/src/lsp/backend.rs
Line 427 in b8505c5
we should also unset the events channel in
RMain
that we sent it here:ark/crates/ark/src/lsp/backend.rs
Lines 397 to 403 in b8505c5
because there is no longer anything it can send messages to.
The tower-lsp server will exit like this during a Positron developer refresh, so it is a decently common case. I think it is possible for us to get in a bad place if we don't clear the
RMain
sender.The text was updated successfully, but these errors were encountered: