Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start_crop and end_crop remain zero when recording with a crop #149

Open
nvbln opened this issue Feb 27, 2024 · 1 comment
Open

start_crop and end_crop remain zero when recording with a crop #149

nvbln opened this issue Feb 27, 2024 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@nvbln
Copy link
Contributor

nvbln commented Feb 27, 2024

An example excerpt of the stack metadata:
{"shape_full": [18001, 1, 608, 690], "shape_block": [562, 1, 608, 690], "crop_start": [0, 0, 0, 0], "crop_end": [0, 0, 0, 0], "padding": [0, 0, 0, 0], "voxel_size": [24.08, 0.6, 0.6]}
In this recording, a crop was used, as is evident by shape_full and shape_block (the camera is 2048 by 2048). However, both crop_start and crop_end do not contain any information on the start and end of the crop. Instead, crop_start should contain the position of the start of the crop and crop_end should contain the position of the end of the crop.

@nvbln nvbln added the bug Something isn't working label Mar 1, 2024
@nvbln
Copy link
Contributor Author

nvbln commented Mar 1, 2024

It looks more like it has not been implemented yet:

json.dump(
{
"shape_full": (
self.n_volumes,
*self.current_data.shape[1:],
),
"shape_block": (
self.save_parameters.chunk_size,
*self.current_data.shape[1:],
),
"crop_start": [0, 0, 0, 0],
"crop_end": [0, 0, 0, 0],
"padding": [0, 0, 0, 0],
"voxel_size": self.save_parameters.voxel_size,
},

@nvbln nvbln added the enhancement New feature or request label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant