Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a JSON validation to validate each PR #11

Open
deviantony opened this issue Sep 14, 2016 · 2 comments
Open

Add a JSON validation to validate each PR #11

deviantony opened this issue Sep 14, 2016 · 2 comments
Labels
enhancement

Comments

@deviantony
Copy link
Member

When a PR is created, it should trigger a hook on some CI instance to execute a JSON validation against the templates.json file.
@G07cha
Copy link

G07cha commented Jul 5, 2017 •
edited
Loading

I'm interested in implementing it! Do you have any CI preference(I was thinking about Travis)?
I also think that we might want to validate it against a specific schema, what are your thoughts about it?

@deviantony
Copy link
Member Author

We're using Codefresh as our CI tool. Tho this was open a long time ago and has a really low priority. I'd rather see you contributing on something more important, you can ping me on Slack as I've got a nice list of opened issues to solve before that one ;-)

UiP9AV6Y added a commit to UiP9AV6Y/portainer-templates that referenced this issue Apr 2, 2018
@UiP9AV6Y
create CI pipeline to validate template manifest.
500e696 
using python-jsonschema to validate the template catalog.

relates to portainer/templates#11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@deviantony @G07cha