Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the "Enter" key to press the "Open" button #61

Open
hardBSDk opened this issue Jul 17, 2024 · 6 comments
Open

Allow the "Enter" key to press the "Open" button #61

hardBSDk opened this issue Jul 17, 2024 · 6 comments

Comments

@hardBSDk
Copy link

Like all other xdg-desktop-portal implementations.

@hardBSDk
Copy link
Author

@mmstick Does #56 also implemented for the file picker?

@mmstick
Copy link
Member

mmstick commented Jul 18, 2024

No, just the screenshot overview

@hardBSDk
Copy link
Author

@PhantomShift Can you implement this for the file picker?

@PhantomShift
Copy link
Contributor

PhantomShift commented Jul 18, 2024

I only implemented #56 since it was super trivial to add, but since I was specifically mentioned, I will ask the clarifying question, what exactly do you mean "Allow the enter key to press the open button"? When I initially read this I assumed it meant opening files in cosmic-file with the enter button but that already works (albeit with some broken xdg mime types, opening binaries for example does not attempt to execute them), and I'm not very familiar with the freedesktop spec so I'm not sure what the title of this issue is referring to.

@PhantomShift
Copy link
Contributor

PhantomShift commented Jul 18, 2024

Ah I see now that although it shares code, the file picker is actually distinct from the cosmic-files application and currently doesn't implement any hotkeys/keyboard navigation.

@hardBSDk
Copy link
Author

@PhantomShift I mean the "Open" button from the file picker dialog, maybe the confirmation button has other names based on the program context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants