-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
galp5 performance mode should be tuned #210
Comments
I believe a TDP of 40W is acceptable for the galp5 on performance mode. The limit you see when on DC is to prevent overdrawing the battery. It is critical that this limit remains in place. |
@jackpot51 you're referring to this in regards to overdrawing the battery? As as end user increasing that limit, am I risking a shorter battery life (in terms of discharge cycles) or risking catastrophic battery failure or board failure? As far as the 40W TDP, without any modifications galp5 i7 will boost to 44-45W on its own. The increased thermal throttle point of 93C and boost time window (as long as possible) are what I'd like to see added to performance mode. |
Overdrawing can result in lower battery lifespan or system shutdowns. The PL2 can be set to 51 as it currently is but PL1 should probably not exceed 40W to avoid thermal runaway |
@jackpot51 thanks for those details. Any opposition to greatly expanding the Tau and increasing the thermal throttle point for performance mode? |
If you adjust PL1 tau doesn't need to be adjusted. PL1 is indefinite |
Thermal throttle at 93C should be fine in performance mode |
Here's default MSR on cold boot connected to AC power, balanced power profile:
And here's what pcm looks like for the first 28 seconds of a heavy workload:
|
If I increase that Tau (and nothing else) with the below, it'll maintain that high TDP of 40+W
|
I recommend instead adjusting the pl1 to 40W because it is easier to inspect than a tau change. Also, the default tau is useful for defining a short-term power limit as PL2. With tau set so large, these two limits essentially merge together. Try creating ModelProfiles similar to the lemp9 at the end of src/daemon/profiles.rs. The balanced pl1 is 28, pl2 is 51, tcc_offset is 12. For performance, pl1 could be 40, pl2 51, and tcc_offset 7. For battery, the values from the lemp9 are reasonable. |
@jackpot51 I can try working on a PR for what you describe, but it seems that just adjusting the pl1 results in a TDP of 33-37W (just under themal limits) whereas just increasing the time window results in 40-45W (thermal limits). I'm new to all this, but I've also noticed that if I increase the pl1 without increasing the time window and then increase the time window, I'll still be limited to that 35W TDP. This difference in TDP determines whether one is able to achieve max all-core turbo. |
How are you measuring CPU power usage? |
See what measurements you get from this script: https://github.com/system76/ec/blob/master/power.sh It creates a CSV file called power.csv where a bunch of power and thermal metrics are stored, and is what we generally use to evaluate fan curves |
@jackpot51 thanks for that tip, helpful to see the readings over time. I'll open a PR for adding the galp5 profile. |
Distribution (run
cat /etc/os-release
):Issue/Bug Description:
With performance power profile selected on AC power for i7-1165G7:
Writing MSRs (93C, pl1 45W 99999) results in:
Other Notes:
The text was updated successfully, but these errors were encountered: