From 0ecad7a146a8908852b025804c59b24816a76561 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Richard=20Hoz=C3=A1k?= <5235838+richardhozak@users.noreply.github.com> Date: Sat, 16 Nov 2024 21:45:42 +0100 Subject: [PATCH] Revert "Fix `Noto Color Emoji` font fallback order for Unix" This reverts commit 66288ab2da9e5e9e74ede1ed081e581058ab4cca. Note that putting "Noto Color Emoji" anywhere lower (even just below "DejaVu Sans") creates issue described in https://github.com/pop-os/cosmic-text/issues/327 Putting it above "Noto Sans" breaks text rendering completely. With the commit reverted I cannot reproduce the original issue https://github.com/pop-os/cosmic-text/pull/68 the commit 66288ab2da9e5e9e74ede1ed081e581058ab4cca was supposed to fix. --- src/font/fallback/unix.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/font/fallback/unix.rs b/src/font/fallback/unix.rs index 11b58ec697..0325c512e3 100644 --- a/src/font/fallback/unix.rs +++ b/src/font/fallback/unix.rs @@ -8,6 +8,8 @@ pub fn common_fallback() -> &'static [&'static str] { &[ /* Sans-serif fallbacks */ "Noto Sans", + /* Emoji fallbacks*/ + "Noto Color Emoji", /* More sans-serif fallbacks */ "DejaVu Sans", "FreeSans", @@ -18,8 +20,6 @@ pub fn common_fallback() -> &'static [&'static str] { /* Symbols fallbacks */ "Noto Sans Symbols", "Noto Sans Symbols2", - /* Emoji fallbacks*/ - "Noto Color Emoji", //TODO: Add CJK script here for doublewides? ] }