Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing callbacks related to datasets #113

Open
khatchad opened this issue Dec 4, 2023 · 1 comment · May be fixed by ponder-lab/ML#83
Open

Missing callbacks related to datasets #113

khatchad opened this issue Dec 4, 2023 · 1 comment · May be fixed by ponder-lab/ML#83
Labels
enhancement New feature or request

Comments

@khatchad
Copy link
Collaborator

khatchad commented Dec 4, 2023

Missing experimental_distribute_datasets_from_function

Called here: https://github.com/mead-ml/mead-baseline/blob/5d7632bb151c2d09501ebf49f36ba8c4204df4c8/mead/api_examples/pretrain_discrim_tf.py#L307

The callback function is dataset_test_fn, defined here: https://github.com/mead-ml/mead-baseline/blob/master/mead/api_examples/pretrain_discrim_tf.py#L301-L306

But that function doesn't show up in the call graph. The method reference should be: < PythonLoader, Lscript pretrain_discrim_tf.py/get_dataset, do()LRoot; >. However, we don't see it in the call graph nodes: https://gist.github.com/khatchad/bd48384f3561fdcc7c8c6e9141d93de5

Related to #92 and blocked on #89.

@khatchad khatchad self-assigned this Dec 6, 2023
@khatchad khatchad added the enhancement New feature or request label Dec 6, 2023
@khatchad khatchad removed their assignment Dec 6, 2023
@khatchad khatchad linked a pull request Feb 5, 2024 that will close this issue
@khatchad khatchad linked a pull request Feb 15, 2024 that will close this issue
@khatchad
Copy link
Collaborator Author

khatchad commented Mar 1, 2024

We might be at the point where we can now fix this if we can treat distributed values as datasets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant