Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract tf.function decorator arguments #136

Closed
tatianacv opened this issue Jan 15, 2023 · 6 comments · May be fixed by #144
Closed

Extract tf.function decorator arguments #136

tatianacv opened this issue Jan 15, 2023 · 6 comments · May be fixed by #144

Comments

@tatianacv
Copy link
Member

tatianacv commented Jan 15, 2023 •
edited by khatchad
Loading

Currently, we are not dealing with tf.function decorator parameter values, just with the existence of those parameters.

Do we need dataflow or does parsing literals enough? How often are variables used to decorator arguments? Can we tell when variables are used? If we go only with literals, can we throw an exception when a variable is used so that we know how many times this happens. Better yet, we can "fail" the function by adding a precondition failure to the function. In other words, if we can't exact the decorator argument, chances are we won't be able to get a good handle on the function's status.
@khatchad
Copy link
Member

tf.function parameter values sounds ambigious because when a function is transformed to a tf.function, we typically cal that a tf.function. So, which parameters are we approximating, the one from the function or the one from the decorator? Both may have parameters.

@tatianacv
Copy link
Member Author

tatianacv commented Jan 20, 2023 •
edited
Loading

Understood, thanks. Yeah, I updated that to make it more clear in the description. I believe we will need information both on the function and on the decorator, but this issue is related to the decorator's parameter values.

@khatchad khatchad changed the title Get the tf.function's parameter values Get tf.function decorator arguments Jan 24, 2023
@khatchad
Copy link
Member

parameter values = arguments (title simplification)

@khatchad khatchad changed the title Get tf.function decorator arguments Extract tf.function decorator arguments Jan 26, 2023
@tatianacv tatianacv mentioned this issue Feb 10, 2023
Open
15 tasks
@khatchad
Copy link
Member

khatchad commented Jun 2, 2023

Isn't this the same as #111?

@tatianacv
Copy link
Member Author

Yes, it seems that way.

@khatchad
Copy link
Member

khatchad commented Jun 2, 2023

Dupe of #111.

@khatchad khatchad closed this as completed Jun 2, 2023
@khatchad khatchad reopened this Jun 2, 2023
@khatchad khatchad closed this as not planned Won't fix, can't repro, duplicate, stale Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extract tf.function decorator keyword arguments tatianacv/Hybridize-Functions-Refactoring
2 participants
@khatchad @tatianacv