Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enlarge images and videos on click #308

Open
vogti opened this issue Mar 31, 2021 · 23 comments · May be fixed by polypheny/Polypheny-UI#85
Open

Enlarge images and videos on click #308

vogti opened this issue Mar 31, 2021 · 23 comments · May be fixed by polypheny/Polypheny-UI#85
Assignees
@TejasSaraf
Labels
A-ui Area: UI C-enhancement Category: An issue proposing an enhancement E-good-first-issue P-medium Priority: Medium

Comments

@vogti
Copy link
Member

vogti commented Mar 31, 2021

The data view in Polypheny-UI makes it possible to view images and videos. The multimedia objects in the table view and card view are displayed rather small. It would be great to integrate a lightbox plugin. Preferably, it should be possible to display the information of the other columns in a caption at the bottom, but this is not a must.

A great plugin to use is: https://www.npmjs.com/package/ngx-lightbox

Please make sure that the animations are fast so that it is possible to switch quickly between the images.
@vogti vogti added C-enhancement Category: An issue proposing an enhancement A-ui Area: UI P-medium Priority: Medium E-good-first-issue labels Mar 31, 2021
@vogti vogti changed the title Enlarge images / videos on click Enlarge images and videos on click Mar 31, 2021
@JAgrit20
Copy link

JAgrit20 commented Apr 7, 2021

Sir, if you can pinpoint the file/folder where I shall implement the changes?

@nilshansen94
Copy link
Member

Hi @JAgrit20, the table view and card view can be found in the following directories:
Polypheny-DB-UI/src/app/components/data-view/data-card
Polypheny-DB-UI/src/app/components/data-view/data-table
Maybe you have to work with the media component as well:
Polypheny-DB-UI/src/app/components/data-view/media.
To test, you will have to create a table with an IMAGE and VIDEO column and add some data. In the UI, when you select a table in the data view you can switch between the table, carousel and card views. It would be good to integrate the lightbox plugin into the table and card views.

@Pawanupadhyay10
Copy link

HI,i will like to contribute on it, Can you assign this issue to me.

@vogti
Copy link
Member Author

vogti commented Apr 9, 2021

Hi @Pawanupadhyay10, @JAgrit20 is already working on this issue, but there are several other interesting issues you can work on.

@JAgrit20
Copy link

JAgrit20 commented Apr 9, 2021

@vogti thanks, I am working on this,
if you can see my timeline which I have submitted as a proposal once for GSOC, please?

@BrokenArrow1404
Copy link

BrokenArrow1404 commented Mar 22, 2022 •
edited
Loading

Hi, I would like to know is this problem still available in GSOC 2022?

@heitzli
Copy link

heitzli commented Mar 23, 2022

Hi @BrokenArrow1404 it would be great if you could handle that issue. I assigned it to you.

@BrokenArrow1404
Copy link

Hi @BrokenArrow1404 it would be great if you could handle that issue. I assigned it to you.

got it and thanks

@vogti
Copy link
Member Author

vogti commented Apr 13, 2022

Hi @BrokenArrow1404 Do you have any questions?

@BrokenArrow1404
Copy link

Sorry, I can't continue working on this project due to personal reasons.

@vogti
Copy link
Member Author

vogti commented Apr 13, 2022

Ok, if you have time again, please do not hesitate to reach out to us :)

@Nishant-dobaria
Copy link

hello sir, I want to know if this problem still open?

@vogti
Copy link
Member Author

vogti commented May 8, 2022

Yes, this issue is still open. Do you want to take care of it?

@Nishant-dobaria
Copy link

yes with pleasure, I am not familiar with angular but in order to solve that problem I first learn little bit about angular and then I approach to that problem.
problem statement is : Enlarge images and videos on click like this right?
ngx-box

@vogti
Copy link
Member Author

vogti commented May 8, 2022

Yes, exactly. Great, I have assigned you the issue.

@Nishant-dobaria
Copy link

Nishant-dobaria commented May 15, 2022 via email

@msaini28r
Copy link

msaini28r commented Sep 27, 2022 •
edited
Loading

@vogti Hi, I would like to work on this issue. If it is available.

@AK4266
Copy link

AK4266 commented Feb 22, 2023

Hello, i would like to work on this issue

@deepankar2704
Copy link

Hello sir I am currently worked on this type of problem. Can I get a chance to solve this issue?

@alyaa999 alyaa999 linked a pull request Mar 7, 2024 that will close this issue
Open
@alyaa999
Copy link

alyaa999 commented Mar 7, 2024 •
edited
Loading

Hi , @vogti I'm coming from GSOC 2024 .Could you review my PR ?

@Sanchit3004
Copy link

Hello @vogti sir, I am 3rd year B.E.(IT) student. I would like to work on this issue for my GSOC'24. Is this issue still open? If yes, then please assign it to me.

@hennlo hennlo assigned hennlo and alyaa999 and unassigned hennlo Mar 12, 2024
@TejasSaraf
Copy link

Hii @vogti, I would like to work on this issue can you assign it to me?

@vogti vogti assigned TejasSaraf and unassigned alyaa999 Oct 19, 2024
@SidraAnsari
Copy link

SidraAnsari commented Dec 29, 2024 •
edited
Loading

Hi! I would like to work on this issue for my GSOC'25 project. Is this issue still open? If yes, then please assign it to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TejasSaraf TejasSaraf

Labels
A-ui Area: UI C-enhancement Category: An issue proposing an enhancement E-good-first-issue P-medium Priority: Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enlarge images and videos on click alyaa999/Polypheny-UI