Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better import for Plan Builder #254

Open
vogti opened this issue Aug 24, 2020 · 9 comments · May be fixed by polypheny/Polypheny-UI#87
Open

Better import for Plan Builder #254

vogti opened this issue Aug 24, 2020 · 9 comments · May be fixed by polypheny/Polypheny-UI#87
Labels
A-ui Area: UI C-enhancement Category: An issue proposing an enhancement E-good-first-issue P-medium Priority: Medium

Comments

@vogti
Copy link
Member

vogti commented Aug 24, 2020

Add a larger text field and add support for uploading a file containing the JSON.

grafik

This should be handled completely within the UI.

@vogti vogti added C-enhancement Category: An issue proposing an enhancement A-ui Area: UI E-easy P-medium Priority: Medium labels Aug 24, 2020
@Chamodii
Copy link

Hi! I'd like to work on this issue.

@vogti
Copy link
Member Author

vogti commented Mar 17, 2021

Hi @Chamodii, welcome to Polypheny! Thank you for taking care of this. I have assigned the issue to you. Please follow this on how to set up Polypheny-DB in your favorite IDE and this guide on how to manually build Polypheny-UI. Feel free to ask here or open a thread in the discussion forum if you have any questions or experience any issues with setup.

@vogti
Copy link
Member Author

vogti commented Apr 2, 2021

Hi @Chamodii, is everything working fine? If you have any issues or need help getting started, please do not hesitate to either ask here or open a thread in the discussion forum.

@S-Harshit
Copy link
Contributor

If @Chamodii is not working on the issue, Can I work on it?

@vogti vogti assigned S-Harshit and unassigned Chamodii Apr 14, 2021
@vogti
Copy link
Member Author

vogti commented Apr 14, 2021

Yes, of course. Thank you for taking care of it.

@S-Harshit
Copy link
Contributor

Hi @vogti, I am little stuck and need some help currently prompt() method is used to display the input field and it doesn't allow changing the field size or adding additional button for file input so a custom prompt would need to be created, I am not sure whether I am right or not also if it has to be created I haven't found the right approach so if you can guide me a little that would be helpful.

@datomo
Copy link
Member

datomo commented May 1, 2021

Hey @S-Harshit
You are absolutly right, prompt is used to display the modal from the user and get their input.
And you are also correct by observing that you would need to change it to a diffrent popup/modal function to be able to change it according to your needs, as the used prompt is rather basic.
Luckly, Angular has a lot of ways to do that.
For one you could use some form of the modal, which comes with our used template framework:
https://coreui.io/docs/2.1/components/modal/

This modal is used throught the UI of Polypheny, for example, for the deployment of the adapters:
https://github.com/polypheny/Polypheny-UI/tree/master/src/app/views/adapters

To make it work, you would need to add the modal in the html code and place it according to your needs and add the desired fields, and hide it.
Then you probably would need to seperate the import function to just show the modal. When the values then are inserted in the model you could bind them to variables and by submitting you could call the remainder logic of the import function, where you grab the changed variables.

I hope, I could give you some good pointers, if you have any questions, feel free to ask again.

@EslamAsHhraf
Copy link

@vogti Hi, can you assign me this issue, I believe i can solve it

@EslamAsHhraf EslamAsHhraf linked a pull request Mar 13, 2024 that will close this issue
3 tasks
@EslamAsHhraf
Copy link

@vogti @datomo Hi everyone,
I'm coming from GSOC 2024 . Could you review my PR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ui Area: UI C-enhancement Category: An issue proposing an enhancement E-good-first-issue P-medium Priority: Medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants