-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github action - maturin version uncompatibleness #6
Comments
Also, In other your library py-bip39-bindings in your |
In recent versions of |
Important to mention is that soon these bindings will be replaced by https://github.com/polkascan/py-ed25519-zebra-bindings because of security issues mentioned here #4 in the |
I added musllinux builds and publish to PyPI, also for the zebra bindings. Let me know if this works for you now |
I check, and everything is working now. Thank you very match. |
About this library. Here, you forget to add to you action one requirement - here. You forget to add "musllinux" action and your last action "release" doesn't wait "musllinux" action to complete and upload to PyPi wheels. As result, no wheels for musl on Pypi. |
Good find, thanks for pointing this out. Re-initiated release: https://github.com/polkascan/py-ed25519-zebra-bindings/actions/runs/3037717851 |
One more thing to you: now I can't find wheels for "manylinux" for aacrh64 on Pypi - https://pypi.org/project/py-ed25519-bindings/#files. Can you upload them to PyPi? |
And I can't find action, where you actually build them for |
Yes I didn't find a way at that time to build those with Github actions, so I build them manually with a RPi4 (which I hopelessly forgot). Because of your addition I am looking into Help would be appreciated! :) |
Hi, it's me again. |
second one here - polkascan/py-sr25519-bindings#9 |
and the last one - polkascan/py-ed25519-zebra-bindings#2 |
Ok merged and the actions ran, all available on PyPI. Thanks again for contributing, this will make the following releases much easier |
Good, thank you. |
Hi, Now i'm working with you github actions. I want to and wheels for
musllinux
- now you only have them formanylinux
. I've made the part of github action with wheels formusllinux
(for all platforms) and decided to integrate this part in your main action "pypi.yml" and found a problem:You create wheels with
maturin
package. I've run your action and got the following error :Full logs you can find here.
As I have figured, this is a version-related issue. The last time you have created wheels with action was 9 months ago. Actual version of
maturin
was 0.12.4. And everything was OK. But now actual version is 0.13.2 and they have reworked key words and there is no more--no-sdist
and action fails.What can we done, to avoid this issue?
The text was updated successfully, but these errors were encountered: