add hrmp messages #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gavofyork Do we need to worry bit more about grouping message types? Right now we have three kind of messages: Instruction, Notification and Query. I am worried it will become bit messy if we just simply adding messages types in the sequential order. |
pepyakin
approved these changes
Mar 10, 2021
Closed
|
V2 includes correct HRMP messages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied message from https://github.com/paritytech/polkadot/blob/cb95b9a3cd3d3217bc911f97227d927c26f75dba/xcm/src/v0/mod.rs#L162-L205
Add new one to allow parachain to perform HRMP related actions without using Transact
Closes #9
cc @pepyakin @shaunxw
I would like to get those in before I add new messages to avoid conflicts in message type index