Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref counted types missing pointer comparison optimization for eq #9

Closed
epage opened this issue Oct 10, 2023 · 1 comment · Fixed by #12
Closed

Ref counted types missing pointer comparison optimization for eq #9

epage opened this issue Oct 10, 2023 · 1 comment · Fixed by #12
Assignees
Labels
enhancement New feature or request

Comments

@epage
Copy link

epage commented Oct 10, 2023

Arc<str> compares pointers first which normal reference equality checks do not perform.

See https://htmlpreview.github.io/?https://github.com/epage/string-benchmarks-rs/blob/master/runs/2023-10-10/eq/report/index.html for a benchmark showcasing the behavior from this

@polazarus polazarus self-assigned this Oct 30, 2023
@polazarus polazarus added the enhancement New feature or request label Oct 30, 2023
@polazarus
Copy link
Owner

Sorry for the delay! Good catch! Really nice work on string Rosetta too

Updated link: https://htmlpreview.github.io/?https://github.com/rosetta-rs/string-rosetta-rs/blob/master/runs/2023-10-10/self_eq/report/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants