Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a standard for QR Codes #334

Open
nodiesBlade opened this issue Mar 12, 2022 · 1 comment
Open

Creating a standard for QR Codes #334

nodiesBlade opened this issue Mar 12, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@nodiesBlade
Copy link

nodiesBlade commented Mar 12, 2022

Is your feature request related to a problem? Please describe.
My team is currently creating a mobile wallet that will send/receive transactions through QR code scanning. Given that there are very few wallets to use right now, I couldn't find a standard that was adopted yet in Pocket.

Describe the solution you'd like
The goal of the feature request is to define a standard that will be adopted across multiple wallets as Pocket continues to grow. I would like to aim for this standard to be cross compatible with v1.0

Instead of reinventing the wheel, I propose we define a format derived from BIP-0021 and ERC-67

Optional Parameters:

  • memo
  • amount (upokt)
  • fee (upokt)

Examples

Address
pocket:<address>

Address with Memo
pocket:<address>?memo=<value>

Address with Address, Memo, and Amount
pocket:<address>?memo=<value>&amount=<value2>

Address with Address, Memo, Amount, Fee
pocket:<address>?memo=<value>&amount=<value2>&fee=<value3>

Describe alternatives you've considered
Open to ideas

Additional context
There's been QR code mishaps in other platforms (wallets and crypto exchanges) that has resulted in users losing funds. This all stems back from standard inconsistencies and different formats that apps adopt. The sooner we define this, the better.

@nodiesBlade nodiesBlade added the enhancement New feature or request label Mar 12, 2022
@nodiesBlade
Copy link
Author

nodiesBlade commented Mar 12, 2022

Once a standard is defined, I'll create a PR to add QR code functionality to pocketjs/web wallet. (Could be useful for users who are using using the web wallet on mobile)

@nodiesBlade nodiesBlade changed the title Creating a standard for QR Code sending and receiving Creating a standard for QR Codes Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant